From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4AF3B64405 for ; Tue, 6 Oct 2020 13:25:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44D5125270 for ; Tue, 6 Oct 2020 13:25:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BAE2425263 for ; Tue, 6 Oct 2020 13:25:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8678E45A8B for ; Tue, 6 Oct 2020 13:25:13 +0200 (CEST) From: Thomas Lamprecht To: Proxmox Backup Server development discussion , Dominik Csapak Reply-To: Proxmox Backup Server development discussion References: <20201006102528.15383-1-d.csapak@proxmox.com> <20201006102528.15383-5-d.csapak@proxmox.com> Message-ID: Date: Tue, 6 Oct 2020 13:25:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.146 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 5/6] ui: Dashboard/TaskSummary: add Verifies to the Summary X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2020 11:25:44 -0000 On 06.10.20 13:10, Thomas Lamprecht wrote: > On 06.10.20 12:25, Dominik Csapak wrote: >> and count every type that starts with 'verify' (e.g. verifyjob) >> >> Signed-off-by: Dominik Csapak >> --- >> www/Dashboard.js | 6 ++++++ >> www/dashboard/TaskSummary.js | 1 + >> 2 files changed, 7 insertions(+) >> > > > I have some weird stuff going on here, namely, I get tasks with the same upid > multiple times in the store?? > > This screws up the counts, e.g., verifies are counted all double, gc are also > more (but here not doubled!) > > I.e., if I apply the below diff I get different numbers, now matching with the > actual task list which opens when clicking on such a summary number.. > > diff --git a/www/Dashboard.js b/www/Dashboard.js > index 1a68029f..0597194b 100644 > --- a/www/Dashboard.js > +++ b/www/Dashboard.js > @@ -150,7 +150,12 @@ Ext.define('PBS.Dashboard', { > verify: { error: 0, warning: 0, ok: 0 }, > }; > > + let upid_seen = {}; > records.forEach(record => { > + if (upid_seen[record.data.upid]) { > + return; > + } > + upid_seen[record.data.upid] = 1; > let type = record.data.worker_type; > if (type === 'syncjob') { > type = 'sync'; > ignore me, this is a side effect of left over from when I tried to reproduce some task log active to index move behavior, I may have duplicated some tasks there by accident.