From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CEE999E86E for ; Tue, 28 Nov 2023 10:57:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B16B913FFE for ; Tue, 28 Nov 2023 10:57:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 28 Nov 2023 10:57:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D9E5944D0B for ; Tue, 28 Nov 2023 10:57:40 +0100 (CET) Message-ID: Date: Tue, 28 Nov 2023 10:57:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox Backup Server development discussion , Philipp Hufnagl References: <20231109144329.1830522-1-p.hufnagl@proxmox.com> <20231109144329.1830522-3-p.hufnagl@proxmox.com> From: Lukas Wagner In-Reply-To: <20231109144329.1830522-3-p.hufnagl@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 2/3] ui: Show if Filter includes or excludes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2023 09:57:41 -0000 On 11/9/23 15:43, Philipp Hufnagl wrote: > To make the UI compatible, the Group Filter dialogue has been extended > by a second list, so it now features a list for all include filter and > one for all exclude filters. > > Internally, all include as well as exclude filter are managed into one > list. The 2 list view is just for a cleaner representation in the UI. > The edit window becomes pretty tall with the second grid for the excludes. Assuming a screen resolution of 1368x768 (which is still in use in some low-end laptops) and subtracting a few pixels for task/menu bars, the edit window is not really usable on a screen with that resolution. You can test/simulate that by pressing Ctrl-Shift-M in Firefox while being in web inspector view. Maybe we could have the exludes in the same grid view, but sort it so that the 'includes' come before 'exludes'? Alternatively, we could reduce the height of the two grid views (not sure how many rules people have on average, it'd be bad if people have to scroll a lot) -- - Lukas