From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9A3321FF13B for ; Wed, 06 May 2026 16:08:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2BDBC22BA7; Wed, 6 May 2026 16:08:32 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 06 May 2026 16:08:28 +0200 Message-Id: Subject: Re: [PATCH proxmox-backup v2 1/5] fix #6691: allow search by comment in datastore content From: "Shan Shaji" To: "Erik Fastermann" , X-Mailer: aerc 0.20.0 References: <20260506121332.21896-1-e.fastermann@proxmox.com> <20260506121332.21896-2-e.fastermann@proxmox.com> In-Reply-To: <20260506121332.21896-2-e.fastermann@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778076401361 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.151 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XHG277LSK64M4LCTVKDTDF3PYMMU5XWG X-Message-ID-Hash: XHG277LSK64M4LCTVKDTDF3PYMMU5XWG X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, Applied and tested this change, I was able to search by comment. The code changes also looks good. Reviewed-by: Shan Shaji Tested-by: Shan Shaji On Wed May 6, 2026 at 2:13 PM CEST, Erik Fastermann wrote: > Use case-insensitive matching, also for text and owner. > > Signed-off-by: Erik Fastermann > --- > > changes since v1: > * use case-insensitive matching for all fields, but with toLowerCase > > www/datastore/Content.js | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/www/datastore/Content.js b/www/datastore/Content.js > index 1ec07505d..e963d62f9 100644 > --- a/www/datastore/Content.js > +++ b/www/datastore/Content.js > @@ -933,15 +933,13 @@ Ext.define('PBS.DataStoreContent', { > }, > =20 > filter: function (item, value) { > - if (item.data.text.indexOf(value) !=3D=3D -1) { > - return true; > - } > - > - if (item.data.owner && item.data.owner.indexOf(value) !=3D= =3D -1) { > - return true; > - } > + const needle =3D value.toLowerCase(); > =20 > - return false; > + return ( > + item.data.text.toLowerCase().includes(needle) || > + (item.data.owner && item.data.owner.toLowerCase().includ= es(needle)) || > + (item.data.comment && item.data.comment.toLowerCase().in= cludes(needle)) > + ); > }, > =20 > search: function (tf, value) { > @@ -1486,7 +1484,7 @@ Ext.define('PBS.DataStoreContent', { > { > xtype: 'textfield', > reference: 'searchbox', > - emptyText: gettext('group, date or owner'), > + emptyText: gettext('group, date, owner or comment'), > triggers: { > clear: { > cls: 'pmx-clear-trigger',