From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D8A0D1FF13F for ; Thu, 23 Apr 2026 16:49:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B7EB81D929; Thu, 23 Apr 2026 16:49:51 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 23 Apr 2026 16:49:17 +0200 Message-Id: Subject: Re: [PATCH proxmox-backup v8 12/13] ui: add move namespace action From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Hannes Laimer" , X-Mailer: aerc 0.21.0 References: <20260422133951.192862-1-h.laimer@proxmox.com> <20260422133951.192862-13-h.laimer@proxmox.com> In-Reply-To: <20260422133951.192862-13-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776955668013 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TGAEYDXLOY55MYMNK3AADYWOIHQJOP4C X-Message-ID-Hash: TGAEYDXLOY55MYMNK3AADYWOIHQJOP4C X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Apr 22, 2026 at 3:39 PM CEST, Hannes Laimer wrote: [snip] > + items: { > + xtype: 'inputpanel', > + onGetValues: function (values) { > + let win =3D this.up('window'); > + let result =3D { > + ns: win.namespace, > + 'target-ns': win.getTargetNs(), > + }; > + if (values['delete-source'] !=3D=3D undefined) { > + result['delete-source'] =3D values['delete-source']; > + } > + if (values['merge-groups'] !=3D=3D undefined) { > + result['merge-groups'] =3D values['merge-groups']; > + } You probably noticed this already, but wanted to mention it nonetheless: these are also not sent to the backend if the checkbox is unchecked. So in this case it would e.g. delete the source even if you unchecked. > + if (values['max-depth'] !=3D=3D undefined && values['max-dep= th'] !=3D=3D '') { > + result['max-depth'] =3D values['max-depth']; > + } > + return result; > + }, > + items: [ > + { [snip]