From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 2B77B1FF13F
	for <inbox@lore.proxmox.com>; Thu, 23 Apr 2026 15:35:46 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 098A01874A;
	Thu, 23 Apr 2026 15:35:46 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 23 Apr 2026 15:35:39 +0200
Message-Id: <DI0KOFVRM077.1AQX8YC29DO3J@proxmox.com>
To: "Hannes Laimer" <h.laimer@proxmox.com>, <pbs-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox-backup v8 11/13] ui: add move group action
From: =?utf-8?q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com>
X-Mailer: aerc 0.21.0
References: <20260422133951.192862-1-h.laimer@proxmox.com>
 <20260422133951.192862-12-h.laimer@proxmox.com>
In-Reply-To: <20260422133951.192862-12-h.laimer@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1776951250434
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.098 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: NYDOXKVEQAGX4LE6IGXXO2GSPMF3ZO2H
X-Message-ID-Hash: NYDOXKVEQAGX4LE6IGXXO2GSPMF3ZO2H
X-MailFrom: m.koeppl@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

On Wed Apr 22, 2026 at 3:39 PM CEST, Hannes Laimer wrote:

[snip]

> +    items: {
> +        xtype: 'inputpanel',
> +        onGetValues: function (values) {
> +            let win =3D this.up('window');
> +            let result =3D {
> +                'backup-type': win.backupType,
> +                'backup-id': win.backupId,
> +                'target-ns': values['target-ns'] || '',
> +            };
> +            if (win.namespace && win.namespace !=3D=3D '') {
> +                result.ns =3D win.namespace;
> +            }
> +            if (values['merge-group'] !=3D=3D undefined) {
> +                result['merge-group'] =3D values['merge-group'];
> +            }

when I uncheck the "Merge Group" checkbox, the `merge-group` param is
not set in the request. since the default value in the backend is
`true`, merging is still attempted.

> +            return result;
> +        },
> +        items: [
> +            {
> +                xtype: 'displayfield',
> +                fieldLabel: gettext('Group'),
> +                cbind: {
> +                    value: '{group}',
> +                },

[snip]