From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id A7BA51FF13B
	for <inbox@lore.proxmox.com>; Wed, 22 Apr 2026 17:19:12 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 83B212406C;
	Wed, 22 Apr 2026 17:19:12 +0200 (CEST)
Content-Type: text/plain; charset=UTF-8
Date: Wed, 22 Apr 2026 17:18:30 +0200
Message-Id: <DHZS8N4UN3XF.25UXQFYNNDYY1@proxmox.com>
Subject: Re: [PATCH proxmox v4 02/30] pbs-api-types: sync job: add optional
 cryptographic keys to config
From: =?utf-8?q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com>
To: "Christian Ebner" <c.ebner@proxmox.com>, <pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
X-Mailer: aerc 0.21.0
References: <20260420161533.1055484-1-c.ebner@proxmox.com>
 <20260420161533.1055484-3-c.ebner@proxmox.com>
In-Reply-To: <20260420161533.1055484-3-c.ebner@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1776871022660
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.098 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: W7UJ5BG2PR2OUHHYEGJEATQPKE3GCDFO
X-Message-ID-Hash: W7UJ5BG2PR2OUHHYEGJEATQPKE3GCDFO
X-MailFrom: m.koeppl@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

On Mon Apr 20, 2026 at 6:15 PM CEST, Christian Ebner wrote:

[snip]

>  const_regex! {
> @@ -664,6 +665,18 @@ pub const UNMOUNT_ON_SYNC_DONE_SCHEMA: Schema =3D
>              type: SyncDirection,
>              optional: true,
>          },
> +        "active-encryption-key": {
> +            schema: CRYPT_KEY_ID_SCHEMA,
> +            optional: true,
> +        },
> +        "associated-key": {

nit: this should probably be "associated-keys"

> +            type: Array,
> +            description: "List of cryptographic keys associated with syn=
c job.",
> +            items: {
> +                schema: CRYPT_KEY_ID_SCHEMA,
> +            },
> +            optional: true,
> +        },
>      }
>  )]
>  #[derive(Serialize, Deserialize, Clone, Updater, PartialEq)]
> @@ -709,6 +722,10 @@ pub struct SyncJobConfig {
>      pub unmount_on_done: Option<bool>,
>      #[serde(skip_serializing_if =3D "Option::is_none")]
>      pub sync_direction: Option<SyncDirection>,
> +    #[serde(skip_serializing_if =3D "Option::is_none")]
> +    pub active_encryption_key: Option<String>,
> +    #[serde(skip_serializing_if =3D "Option::is_none")]
> +    pub associated_key: Option<Vec<String>>,

nit: same here

>  }
> =20
>  impl SyncJobConfig {