From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 291C41FF13B for ; Wed, 22 Apr 2026 11:10:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0534E11395; Wed, 22 Apr 2026 11:10:40 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 22 Apr 2026 11:10:05 +0200 Message-Id: Subject: Re: [PATCH proxmox-backup] acme: partially fix #6372: scale certificate renewal checks by lifetime To: "Christian Ebner" , "Manuel Federanko" , X-Mailer: aerc 0.20.0 References: <20260421144645.275884-1-m.federanko@proxmox.com> <10adc6ba-eaaf-41ae-8585-20c40f590916@proxmox.com> In-Reply-To: <10adc6ba-eaaf-41ae-8585-20c40f590916@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776848919009 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.122 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PQZJPYAUQK5FTCVQEJ5U6KBP3RCO77KW X-Message-ID-Hash: PQZJPYAUQK5FTCVQEJ5U6KBP3RCO77KW X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Apr 22, 2026 at 8:49 AM CEST, Christian Ebner wrote: > On 4/21/26 4:45 PM, Manuel Federanko wrote: >> Start renewing a certificate once 2/3 of its total lifetime have passed, >> instead of the hardcoded 30 days. This stays consistent with many >> certificates, which are valid for 90 days. >> >> The update service runs daily, impose a 3 day minimum remaining lifetime >> to still be able to handle transient failures for certificate renewals. >> >> Signed-off-by: Manuel Federanko >> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=3D6372 >> --- > > @Shannon, can you have a look at this to avoid potential conflicts with > your TLS certificate rotation series [0]? > > [0] > https://lore.proxmox.com/pbs-devel/20260407135714.490747-1-s.sterz@proxmo= x.com/T/#t thanks for the heads-up, but from what i can tell not really. this series addresses acme certificates, whereas mine is only relevant for the self-signed certificates that pbs & pdm fall back on by default. imo it would make sense to have these changes expand to include pdm too, tho.