Re: [PATCH proxmox-backup v3 1/3] api: move statefile loading into compute_schedule_status

Michael Köppl
2026-04-03T11:24:02Z

On Thu Apr 2, 2026 at 6:22 PM CEST, Christian Ebner wrote:

[snip]

>> let mut last = proxmox_time::epoch_i64();
>>
>> + let jobtype = "garbage_collection";
>> +
>> if let Some(ref upid) = status_in_memory.upid {
>> - let mut computed_schedule: JobScheduleStatus = JobScheduleStatus::default();
>> - if let Some(state) = state_file {
>> - if let Ok(cs) = compute_schedule_status(&state, Some(upid)) {
>> - computed_schedule = cs;
>> - }
>> - }
>> + let computed_schedule: JobScheduleStatus =
>> + compute_schedule_status(jobtype, &store, Some(upid))?;
>
> comment: While the change in behavior here when parsing the UPID fails
> is fine as discussed in the previous patch series [0], this must be
> mentioned in the commit message!
>
> A short comment such as:
> ```
> This also changes the error handling for UPID parsing errors with
> garbage collection state files, aligning it to the rest of the API
> handler behavior.
> ```

Missed that, will adapt the commit message in a v4! Thanks

>
> Other than that, consider
>
> Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
>
> [0]
> https://lore.proxmox.com/pbs-devel/DH6UARBSGJYA.172KMABDLD4GQ@proxmox.com/