From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1694D1FF13B for ; Wed, 25 Mar 2026 17:07:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F74A304A0; Wed, 25 Mar 2026 17:08:01 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 25 Mar 2026 17:07:26 +0100 Message-Id: Subject: Re: [PATCH proxmox-backup v2 0/3] fix #7400: improve handling of corrupted job statefiles From: =?utf-8?q?Michael_K=C3=B6ppl?= To: =?utf-8?q?Michael_K=C3=B6ppl?= , X-Mailer: aerc 0.21.0 References: <20260319110318.70346-1-m.koeppl@proxmox.com> In-Reply-To: <20260319110318.70346-1-m.koeppl@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774454798861 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.092 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IQF55XCCI6PQLE5BOCVFR4MQJMV5VXTQ X-Message-ID-Hash: IQF55XCCI6PQLE5BOCVFR4MQJMV5VXTQ X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Superseded-by: https://lore.proxmox.com/pbs-devel/20260325160617.342295-1-m.koeppl@proxmox= .com/T/#t On Thu Mar 19, 2026 at 12:03 PM CET, Michael K=C3=B6ppl wrote: > This patch series fixes a problem where an empty or corrupted job state > file (due to I/O error, abrupt shutdown, ...) would cause API endpoints > for listing jobs to return an error, breaking the web UI for users > because they could not view any of their configured jobs of that type. > It would also cause proxmox-backup-proxy to indefinitely skip the jobs > until a user manually triggered it to rewrite the statefile. > > 1/3 is a preparatory patch that centralizes job statefile loading > in compute_schedule_status instead of having every handler function > open the statefile, handle potential errors and then passing the > JobState to compute_schedule_status. > > 2/3 fixes the API layer by catching the load error, logging an error > message, and returning a default JobScheduleStatus. This ensure the API > returns the job list, showing the affected job without its last run > status. > > 3/3 updates the scheduler loop inside the proxy to match the behavior of > a a newly created job, triggering the job at its next internal (which > then rewrites the statefile). > > changes since v1: > - added preparatory patch 1/3, centralizing the statefile loading before > adapting the handling of the error case in that centralized place > (compute_schedule_status). Thanks, Christian for the suggestion! > - adapted the error message if job statefile loading fails to make clear > that the default status will be returned as a fallback > > > proxmox-backup: > > Michael K=C3=B6ppl (3): > api: move statefile loading into compute_schedule_status > fix #7400: api: gracefully handle corrupted job statefiles > fix #7400: proxy: self-heal corrupted job statefiles > > src/api2/admin/datastore.rs | 13 +++---------- > src/api2/admin/prune.rs | 9 +++------ > src/api2/admin/sync.rs | 9 +++------ > src/api2/admin/verify.rs | 9 +++------ > src/api2/tape/backup.rs | 9 +++------ > src/bin/proxmox-backup-proxy.rs | 2 +- > src/server/jobstate.rs | 17 +++++++++++++++-- > 7 files changed, 31 insertions(+), 37 deletions(-) > > > Summary over all repositories: > 7 files changed, 31 insertions(+), 37 deletions(-)