From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A9E0E1FF138 for ; Wed, 18 Mar 2026 18:04:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3CBC48074; Wed, 18 Mar 2026 18:04:57 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 18 Mar 2026 18:04:23 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Christian Ebner" , =?utf-8?q?Michael_K=C3=B6ppl?= , Subject: Re: [PATCH proxmox-backup v1 1/2] fix #7400: api: gracefully handle corrupted job statefiles X-Mailer: aerc 0.21.0 References: <20260317160722.201693-1-m.koeppl@proxmox.com> <20260317160722.201693-2-m.koeppl@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773853421913 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: X44555ZGVFJNKKJGNOWEYMPNE2K6VXPM X-Message-ID-Hash: X44555ZGVFJNKKJGNOWEYMPNE2K6VXPM X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Mar 18, 2026 at 5:15 PM CET, Christian Ebner wrote: > On 3/17/26 5:07 PM, Michael K=C3=B6ppl wrote: >> Previously, if a job statefile was empty or corrupted (e.g. due to an >> I/O error or an abrupt shutdown), the JobStatus::load method would >> return an error that would be propagated up, causing the endpoint to >> return an error to the user, meaning users would not see any of their >> jobs if a single job had a corrupted statefile. >>=20 >> Instead, handle the error explicitly, logging a warning and returning a >> default JobScheduleStatus, such that jobs lists can still be fetched, >> displaying the affected job as configured but simply missing its last >> run status. >>=20 >> Signed-off-by: Michael K=C3=B6ppl >> --- > > Thanks for the patches, one comment for this patch. > > Instead of adapting all the call sides, loading of the state file might= =20 > be moved to compute_schedule_status() in a preparatory patch, passing=20 > the job type and id as parameters. The improved error handling can then= =20 > be done inside that helper. Thanks for having a look! Yeah, true. Was so busy trying to avoid moving too much stuff around that I didn't see the cleaner solution. Will send an updated v2, thanks for the feedback.