From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B03AA1FF170 for ; Thu, 21 Aug 2025 16:51:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A25732E75A; Thu, 21 Aug 2025 16:51:02 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 21 Aug 2025 16:50:29 +0200 Message-Id: Cc: "pbs-devel" To: "Proxmox Backup Server development discussion" X-Mailer: aerc 0.20.0 References: <20250821141719.4130062-1-s.ivanov@proxmox.com> In-Reply-To: <20250821141719.4130062-1-s.ivanov@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755787829117 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 0/3] pbs3to4: rework bootloader checks X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Thu Aug 21, 2025 at 4:17 PM CEST, Stoiko Ivanov wrote: > v1->v2: > Shannon caught a logic-error (wrong negation) in the check if systemd-boot > is actually used, and a useless temporary variable. additionally patch 2/3 > needed a rustfmt - huge thx! > > supersedes: > https://lore.proxmox.com/pbs-devel/20250818194026.840749-1-s.ivanov@proxmox.com/T/#t > > Stoiko Ivanov (3): > pbs3to4: fix logic error and typo in log message > pbs3to4: use boolean variable for systemd-boot installation state > pbs3to4: bootloader: only allow systemd-boot before upgrade when used > > src/bin/pbs3to4.rs | 61 ++++++++++++++++++++++++---------------------- > 1 file changed, 32 insertions(+), 29 deletions(-) looks good to me, tested this series on the following set ups: - legacy-mode boot -> outputs `SKIP: System booted in legacy-mode - no need for additional packages` - proxmox-boot-tool + grub but without secure boot -> outputs `FAIL: systemd-boot meta-package installed. This will cause problems [..]` - zfs + systemd-boot (no secure boot, but uefi) -> outputs `SKIP: not yet upgraded, systemd-boot still needed for bootctl` so consider this: Reviewed-by: Shannon Sterz Tested-by: Shannon Sterz _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel