From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2C9F71FF165 for ; Thu, 31 Jul 2025 13:25:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6CB7D39198; Thu, 31 Jul 2025 13:26:26 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 31 Jul 2025 13:26:22 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox Backup Server development discussion" , "Christian Ebner" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250730152303.729778-1-c.ebner@proxmox.com> In-Reply-To: <20250730152303.729778-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753961170599 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] datastore: destroy: delete s3 in-use marker unconditionally X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Wed Jul 30, 2025 at 5:23 PM CEST, Christian Ebner wrote: > Currently, the in-use marker object for datastores backed by s3 > backend is only removed together with the data when all data is > requested to be removed. > > It the data should be preserved, the in-use marker should however > also be removed, allowing to reuse the datastore on the same or > a different host without force overwriting the marker. > > Therefore, unconditionally clear the in-use marker from the S3 > object store. In order to use the predefined marker filename > constant move it so it can be used during destruction as well. > > Suggested-by: Lukas Wagner > Signed-off-by: Christian Ebner [...] Looks good to me. Quickly tested this by removing a datastore (without ticking 'remove data') and then reimporting without ticking 'overwrite in-use marker'. Also verified via the `mc` tool that the `.in-use` marker is removed from the bucket, with the `.chunks` and `.cnt` dirs still being in place as expecteded. Reviewed-by: Lukas Wagner Tested-by: Lukas Wagner _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel