From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0CAB11FF170 for ; Thu, 24 Jul 2025 09:54:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 12347327BF; Thu, 24 Jul 2025 09:55:59 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 24 Jul 2025 09:55:26 +0200 Message-Id: From: "Lukas Wagner" To: "Thomas Lamprecht" , "Proxmox Backup Server development discussion" , "Christian Ebner" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250529143207.694497-1-c.ebner@proxmox.com> <00cb5790-78cc-4197-a50e-1779e6c46813@proxmox.com> In-Reply-To: <00cb5790-78cc-4197-a50e-1779e6c46813@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753343724550 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [RFC v2 proxmox/bookworm-stable proxmox-backup 00/42] S3 storage backend for datastores X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Wed Jul 23, 2025 at 4:11 PM CEST, Thomas Lamprecht wrote: > Am 06.06.25 um 13:12 schrieb Lukas Wagner: >> Furthermore, I suggested that maybe the 'bucket' should be a property of the >> datastore config, not of the s3 config. That way, the s3 config contains only the >> connection info and credentials, which make it easy to use the same s3 config for >> multiple datastores which use different buckets as as a backing storage. > > But that promotes re-using a central access secret/token multiple times > vs. having a dedicated token per bucket. Especially as we use a top-level > directory with the datastore name inside the bucket anyway, i.e., one can > use the same bucket easily for multiple datastores already, I do not > think this is great for UX in general besides maybe dev-focused testing. Fair, that's a very valid point, I didn't really view it from that angle. FWIW, I think in v2 this series still created the .chunks 'directory' at the top-level of the bucket; it did not use the datastore name as a prefix, meaning there was a 1:1 mapping of datastore to bucket and no way to use the same bucket for multiple datastores. > > As either I want to have different buckets, where one should always > prefer using dedicated access control for each and now needs to add the > same endpoint twice anyway, or one want's to re-use the same bucket > anyway, which still works if its defined in the endpoint. > > Anyway, if we can sensibly query the list of buckets for the datastore > create, some UX pain will be gone with the newer variant and it can > probably stay, as redoing this now is rather a bit of churn and we are > not locked in here. A trade-off for the future might be to allow > configuring a default bucket in the endpoint, that is auto-filled when > selecting the endpoint in the datastore create window. > > But mostly UX polishing and definitively not pressing for now. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel