From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id DF6561FF16F
	for <inbox@lore.proxmox.com>; Tue, 22 Jul 2025 14:17:16 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 058858CDE;
	Tue, 22 Jul 2025 14:18:31 +0200 (CEST)
Mime-Version: 1.0
Date: Tue, 22 Jul 2025 14:18:28 +0200
Message-Id: <DBIKTJ8Q078O.2JT54EKO2PGQ6@proxmox.com>
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Backup Server development discussion"
 <pbs-devel@lists.proxmox.com>, "Christian Ebner" <c.ebner@proxmox.com>
X-Mailer: aerc 0.20.1-0-g2ecb8770224a
References: <20250722101106.526438-1-c.ebner@proxmox.com>
 <20250722101106.526438-8-c.ebner@proxmox.com>
In-Reply-To: <20250722101106.526438-8-c.ebner@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1753186699885
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.020 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v11 03/46] api: config:
 implement endpoints to manipulate and list s3 configs
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

On Tue Jul 22, 2025 at 12:10 PM CEST, Christian Ebner wrote:
> +
> +#[api(
> +    input: {
> +        properties: {
> +            id: {
> +                schema: JOB_ID_SCHEMA,
> +            },
> +        },
> +    },
> +    returns: { type: S3ClientConfig },
> +    access: {
> +        permission: &Permission::Privilege(&[], PRIV_SYS_AUDIT, false),
> +    },
> +)]
> +/// Read an s3 client configuration.
> +pub fn read_s3_client_config(
> +    id: String,
> +    rpcenv: &mut dyn RpcEnvironment,
> +) -> Result<S3ClientConfig, Error> {
> +    let (config, digest) = s3::config()?;
> +    let s3_client_config: S3ClientConfig = config.lookup(S3_CFG_TYPE_ID, &id)?;
> +    rpcenv["digest"] = hex::encode(digest).into();
> +
> +    Ok(s3_client_config)
> +}

Hmm, maybe we should mask the secret_key in the response? Usually we
don't return any secrets from the API.



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel