From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3AA601FF16F for ; Tue, 22 Jul 2025 11:28:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E1686344E3; Tue, 22 Jul 2025 11:29:25 +0200 (CEST) Date: Tue, 22 Jul 2025 11:29:22 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox Backup Server development discussion" , "Christian Ebner" Mime-Version: 1.0 X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250721164507.1045869-1-c.ebner@proxmox.com> In-Reply-To: <20250721164507.1045869-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753176553630 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v10 00/49] fix #2943: S3 storage backend for datastores X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Did a quick test of this revision as well: - backup - (Live-)restore - tested the client CLI, creating, updating and removing S3 clients - tested "reuse existing datastore" with S3, re-importing a non-empty bucket from a previously deleted datastore - tested a remote push sync job - tested a remote pull sync job Minor observations (these do not block a merge IMO, all material for follow-ups): - Maybe the "Remove Datastore" confirmation dialog should mention that the data in the S3 bucket is not touched (and maybe provide an option to also remove it? Maybe reuse the "destroy all data" flag?) - In the "Create Datastore" dialog, both the "Reuse existing datastore" and "Overwrite in-use marker" checkboxes are enabled when the dialog is created. The second checkbox should only be enabled iff "Reuse existing..." is checked, which it is not by default. Likely just missing the "enabled: false" in the default config. Also quickly went over the issues I raised during my review of v9 and checked how you fixed them. Seems good to me! Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel