From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 5123D1FF15C
for <inbox@lore.proxmox.com>; Fri, 4 Apr 2025 17:41:58 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id DB18736391;
Fri, 4 Apr 2025 17:41:45 +0200 (CEST)
Mime-Version: 1.0
Date: Fri, 04 Apr 2025 17:41:43 +0200
Message-Id: <D8XYVRNB9YJ3.1W9L8XGH9GCM0@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
From: "Max Carrara" <m.carrara@proxmox.com>
X-Mailer: aerc 0.18.2-0-ge037c095a049
References: <20250321080254.68931-1-c.ebner@proxmox.com>
<20250321080254.68931-6-c.ebner@proxmox.com>
In-Reply-To: <20250321080254.68931-6-c.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.081 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH v8 proxmox-backup 5/9] ui: expose GC atime
safety check flag in datastore tuning options
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On Fri Mar 21, 2025 at 9:02 AM CET, Christian Ebner wrote:
> Allow to edit the atime safety check flag via the datastore tuning
> options edit window.
>
> Do not expose the flag for datastore creation as it is strongly
> discouraged to create datastores on filesystems not correctly handling
> atime updates as the garbage collection expects. It is nevertheless
> still possible to create a datastore via the cli and pass in the
> `--tuning gc-atime-safety-check=false` option.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 7:
> - no changes
>
> www/Utils.js | 4 ++++
> www/datastore/OptionView.js | 12 ++++++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/www/Utils.js b/www/Utils.js
> index 2746ef0b5..9bd7e1615 100644
> --- a/www/Utils.js
> +++ b/www/Utils.js
> @@ -846,6 +846,10 @@ Ext.define('PBS.Utils', {
> sync = PBS.Utils.tuningOptions['sync-level'][sync ?? '__default__'];
> options.push(`${gettext('Sync Level')}: ${sync}`);
>
> + let gc_atime_safety_check = tuning['gc-atime-safety-check'];
> + delete tuning['gc-atime-safety-check'];
> + options.push(`${gettext('GC Access Time Safety Check')}: ${gc_atime_safety_check ?? true}`);
> +
> for (const [k, v] of Object.entries(tuning)) {
> options.push(`${k}: ${v}`);
> }
> diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
> index e1f38af6f..eb846ab76 100644
> --- a/www/datastore/OptionView.js
> +++ b/www/datastore/OptionView.js
> @@ -271,6 +271,18 @@ Ext.define('PBS.Datastore.Options', {
> deleteEmpty: true,
> value: '__default__',
> },
> + {
> + xtype: 'proxmoxcheckbox',
> + name: 'gc-atime-safety-check',
> + fieldLabel: gettext('GC atime Check'),
> + autoEl: {
> + tag: 'div',
> + 'data-qtip': gettext('Ensure underlying storage honors access time updates'),
> + },
> + defaultValue: 1,
Since the check it on by default, I assume you want the checkbox in the
UI also to be ticked -- this can be done by using `value` instead of
`defaultValue` above.
> + uncheckedValue: 0,
> + deleteDefaultValue: true,
> + },
> ],
> },
> },
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel