From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 92CA71FF173
for <inbox@lore.proxmox.com>; Mon, 24 Mar 2025 10:44:42 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id DB843F60E;
Mon, 24 Mar 2025 10:44:38 +0100 (CET)
Date: Mon, 24 Mar 2025 10:44:34 +0100
Message-Id: <D8OEEBVMT60H.330NXBAG97SLF@proxmox.com>
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>
Mime-Version: 1.0
X-Mailer: aerc 0.20.1
References: <20250321134541.1106117-1-c.heiss@proxmox.com>
<20250321134541.1106117-2-c.heiss@proxmox.com>
<D8M2LB37M5BG.2GKO1DQCXJ43Q@proxmox.com>
In-Reply-To: <D8M2LB37M5BG.2GKO1DQCXJ43Q@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.029 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [ad.rs, lib.rs]
Subject: Re: [pbs-devel] [PATCH proxmox v5 1/2] fix #5379: api-types: add
`default` field for all realm types
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
Both good catches, thanks!
I'll fix them up for the next revision.
On Fri Mar 21, 2025 at 5:04 PM CET, Shannon Sterz wrote:
> On Fri Mar 21, 2025 at 2:45 PM CET, Christoph Heiss wrote:
[..]
>> diff --git a/pbs-api-types/src/ad.rs b/pbs-api-types/src/ad.rs
>> index 910571a0..5c236325 100644
>> --- a/pbs-api-types/src/ad.rs
>> +++ b/pbs-api-types/src/ad.rs
>> @@ -64,6 +68,9 @@ pub struct AdRealmConfig {
>> /// Comment
>> #[serde(skip_serializing_if = "Option::is_none")]
>> pub comment: Option<String>,
>> + /// True if it should be the default realm to login in
>
> tiniest of nit: "realm to login in" sounds wrong. I think you could just
> remove everything after realm.
Yeah, sounds good, I'll change it to that!
>
>> + #[serde(skip_serializing_if = "Option::is_none")]
>> + pub default: Option<bool>,
>> /// Connection security
>> #[serde(skip_serializing_if = "Option::is_none")]
>> pub mode: Option<LdapMode>,
[..]
>> diff --git a/pbs-api-types/src/lib.rs b/pbs-api-types/src/lib.rs
>> index acc2fca3..e3896000 100644
>> --- a/pbs-api-types/src/lib.rs
>> +++ b/pbs-api-types/src/lib.rs
[..]
>> #[derive(Deserialize, Serialize, Clone, PartialEq)]
>> #[serde(rename_all = "kebab-case")]
>> /// Basic Information about a realm
>> pub struct BasicRealmInfo {
>> + /// Realm name
>> pub realm: String,
>> + // Realm type
>
> nit: this is not a doc-comment, just a regular one
>
>> #[serde(rename = "type")]
>> pub ty: RealmType,
>> /// True if it is the default realm
>> #[serde(skip_serializing_if = "Option::is_none")]
>> pub default: Option<bool>,
>> + /// Optional comment for this realm
>> #[serde(skip_serializing_if = "Option::is_none")]
>> pub comment: Option<String>,
>> }
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel