From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 6CF251FF163
	for <inbox@lore.proxmox.com>; Thu,  5 Dec 2024 13:02:54 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 278D119441;
	Thu,  5 Dec 2024 13:02:54 +0100 (CET)
Mime-Version: 1.0
Date: Thu, 05 Dec 2024 13:02:50 +0100
Message-Id: <D63R2T6163AX.3OPZK2VAXBNB@proxmox.com>
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Backup Server development discussion"
 <pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.18.2-0-ge037c095a049
References: <20241205101820.208631-1-g.goller@proxmox.com>
In-Reply-To: <20241205101820.208631-1-g.goller@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.009 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [pbs.rs, config.rs]
Subject: Re: [pbs-devel] [PATCH] notify: migrate from `log` to `tracing`
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

On Thu Dec 5, 2024 at 11:18 AM CET, Gabriel Goller wrote:
> Migrated from `log` to `tracing`. Imported `tracing` only as it has a
> smaller footprint (and less dependencies) than `proxmox_log`.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  proxmox-notify/Cargo.toml            |  2 +-
>  proxmox-notify/src/config.rs         |  6 ++++--
>  proxmox-notify/src/context/common.rs |  4 +++-
>  proxmox-notify/src/context/pbs.rs    |  8 +++++---
>  proxmox-notify/src/endpoints/smtp.rs |  2 +-
>  proxmox-notify/src/lib.rs            | 25 +++++++++++--------------
>  proxmox-notify/src/matcher.rs        |  5 +++--
>  proxmox-notify/src/renderer/mod.rs   |  3 ++-
>  8 files changed, 30 insertions(+), 25 deletions(-)
>

LGTM!

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel