From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id A1B141FF15F
	for <inbox@lore.proxmox.com>; Mon,  2 Dec 2024 15:42:11 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 5141F1AD06;
	Mon,  2 Dec 2024 15:42:16 +0100 (CET)
Mime-Version: 1.0
Date: Mon, 02 Dec 2024 15:42:14 +0100
Message-Id: <D61AL7R1HK5S.2AYURK44HS0IJ@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>, "Proxmox Backup Server
 development discussion" <pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.18.2-0-ge037c095a049-dirty
References: <20241202141655.254472-1-s.sterz@proxmox.com>
 <D61A64DEHUEY.3QXCMBLLZ0ST9@proxmox.com>
 <5649254d-6c85-49fc-85ef-04598811ef37@proxmox.com>
In-Reply-To: <5649254d-6c85-49fc-85ef-04598811ef37@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.037 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox v3 1/4] sendmail: add sendmail crate
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

On Mon Dec 2, 2024 at 3:33 PM CET, Lukas Wagner wrote:
>
>
> On  2024-12-02 15:22, Shannon Sterz wrote:
> > On Mon Dec 2, 2024 at 3:16 PM CET, Shannon Sterz wrote:
> >> add the `proxmox-sendmail` crate that makes it easier to send mails via
> >> the `sendmail` utility. features include:
> >>
> >> - multipart/alternative support for html+plain text mails
> >> - multipart/mixed support for mails with attachments
> >> - automatic nesting of multipart/alternative and multipart/mixed parts
> >> - masks multiple receivers by default, can be disabled
> >> - encoding Subject, To, From, and attachment file names correctly
> >> - adding an `Auto-Submitted` header to avoid triggering automated mails
> >>
> >> also includes several tests to ensure that mails are formatted
> >> correctly. debian packaging is also provided.
> >>
> >> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> >
> > forgot to add this in the v2 already, but since that is now obsolete,
> > but unless Lukas objects this should probably include:
> >
> > Tested-by: Lukas Wagner <l.wagner@proxmox.com>
> > Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
> >
> > just thought i'd quickly mention this before it gets lost
> >
>
> Changes look good, so no objection from me.
> Only tested v1 and v2, but since this has some serious test coverage
> which I assume you have run before submitting v3, I think
> the T-b is also okay :)

i did and the changes should be contained to proxmox-sendmail in v3 so
hopefully that is all fine. thanks for the quick response time!



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel