From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id EC2BA1FF16B
for <inbox@lore.proxmox.com>; Thu, 28 Nov 2024 12:06:16 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C95407E31;
Thu, 28 Nov 2024 12:06:17 +0100 (CET)
Mime-Version: 1.0
Date: Thu, 28 Nov 2024 12:05:44 +0100
Message-Id: <D5XRHA0D68OD.295FB7HOSGGYR@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.18.2-0-ge037c095a049-dirty
References: <20241128110014.78209-1-s.hanreich@proxmox.com>
In-Reply-To: <20241128110014.78209-1-s.hanreich@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.039 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 1/1] ui: mask unmounted
datastores in datastore overview
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On Thu Nov 28, 2024 at 12:00 PM CET, Stefan Hanreich wrote:
> Currently, showing the Datastore summary page leads to errors since
> the status returned by the API does not contain any fields that are
> checked by the component rendering the datastore summary. We solve
> this by checking if the datastore is currently mounted first and mask
> the element if it is currently unmounted.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> Changes from v1 to v2:
> * unmask element if state changes
>
> www/datastore/DataStoreListSummary.js | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/www/datastore/DataStoreListSummary.js b/www/datastore/DataStoreListSummary.js
> index f7ea83e7..f61e88ec 100644
> --- a/www/datastore/DataStoreListSummary.js
> +++ b/www/datastore/DataStoreListSummary.js
> @@ -35,6 +35,15 @@ Ext.define('PBS.datastore.DataStoreListSummary', {
> let me = this;
> let vm = me.getViewModel();
>
> + if (statusData['mount-status'] === 'notmounted') {
> + let maskMessage = gettext('Datastore is not mounted');
> + let maskIcon = 'fa pbs-unplugged-mask';
> + me.mask(maskMessage, maskIcon);
> + return;
> + } else if (me.isMasked()) {
> + me.unmask();
> + }
> +
> if (statusData.error !== undefined) {
> Proxmox.Utils.API2Request({
> url: `/config/datastore/${statusData.store}`,
this now masks and properly unmasks the datastore, sorry i didn't notice
that before. tested it again, no more errors in the console too, so:
Tested-by: Shannon Sterz <s.sterz@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel