From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 495341FF15E
for <inbox@lore.proxmox.com>; Fri, 23 Aug 2024 08:41:18 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 7489CA90D;
Fri, 23 Aug 2024 08:41:40 +0200 (CEST)
Mime-Version: 1.0
Date: Fri, 23 Aug 2024 08:41:06 +0200
Message-Id: <D3N33T4J1PJJ.81GCV69P9P27@proxmox.com>
Cc: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
From: "Hannes Laimer" <h.laimer@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.18.2-54-g2d9f949ac9a3
References: <20240816111648.483368-1-c.heiss@proxmox.com>
<20240816111648.483368-4-c.heiss@proxmox.com>
<D3JYC5NXG815.1M5LL87IQ3BYC@proxmox.com>
<o4oijkt37keculiqzwaqqlkmizlpocdd7psnnu5z7kvwbepsip@ouucha53ndlt>
In-Reply-To: <o4oijkt37keculiqzwaqqlkmizlpocdd7psnnu5z7kvwbepsip@ouucha53ndlt>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.018 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com]
Subject: Re: [pbs-devel] [PATCH widget-toolkit v3 03/14] window: add panel
for editing simple, built-in realms
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On Thu Aug 22, 2024 at 5:19 PM CEST, Christoph Heiss wrote:
> On Mon, Aug 19, 2024 at 04:18:54PM GMT, Hannes Laimer wrote:
> > On Fri Aug 16, 2024 at 1:16 PM CEST, Christoph Heiss wrote:
> > > Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> > > [..]
> > > diff --git a/src/window/AuthEditSimple.js b/src/window/AuthEditSimple.js
> > > new file mode 100644
> > > index 0000000..22932c0
> > > --- /dev/null
> > > +++ b/src/window/AuthEditSimple.js
> > > @@ -0,0 +1,41 @@
> > > [..]
> > > + {
> > > + xtype: 'proxmoxcheckbox',
> > > + fieldLabel: gettext('Default realm'),
> > > + name: 'default',
> > > + value: 0,
> >
> > nit:
> > this should include
> > ```
> > cbind: {
> > deleteEmpty: '{!isCreate}'
> > },
> > ```
> > IIRC we don't send false, so it works because we PUT, but still
> >
>
> Since this panel is only used for built-in/pre-exisiting realms and no
> new "simple" realms can be created, `isCreate` does not exist anyway.
>
ohh, right, but then just `deleteEmpty: true` without the cbind, no?
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel