From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 983601FF2AF for ; Mon, 22 Jul 2024 07:56:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF03E1C03E; Mon, 22 Jul 2024 07:57:03 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 22 Jul 2024 07:56:29 +0200 Message-Id: To: "Thomas Lamprecht" , "Proxmox Backup Server development discussion" From: "Max Carrara" X-Mailer: aerc 0.17.0-72-g6a84f1331f1c References: <20240716092247.212133-1-m.sandoval@proxmox.com> In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox] rest-server: Encode with zlib headers X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Thu Jul 18, 2024 at 6:08 PM CEST, Thomas Lamprecht wrote: > Am 17/07/2024 um 17:49 schrieb Max Carrara: > > On Tue Jul 16, 2024 at 11:22 AM CEST, Maximiliano Sandoval wrote: > >> As per [RFC9110] the Deflate encoding is a "zlib" data format. This > >> makes the rest-server compatible with the http-client. > >> > >> [RFC9110] https://www.rfc-editor.org/rfc/rfc9110#field.content-encoding > >> > >> Signed-off-by: Maximiliano Sandoval > >> --- > >> > >> By default the builder will use the default compression level. Please let me > >> know if the Level::Default should be set explicitly. > > > > This patch looks simple enough to me and does what it says on the tin; > > I can't really spot anything wrong here. > > Does the "does what it says on the tin" part also mean you tested this > explicitly? Just wondering why no T-b was given and how closely I need > to check this out ;-) Maybe I should use less colorful sayings next time, but no, I hadn't tested this, hence the missing T-b tag ;) Though, for good measure I tested it now - all responses use the "Content-Encoding: deflate" header and compress the correctly in Firefox. Furthermore, when making a request without the header, the content is not encoded at all (tested with curl). So, my trailers are now as follows: Reviewed-by: Max Carrara Tested-by: Max Carrara _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel