From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3829C1FF39B for ; Mon, 13 May 2024 11:31:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 65821120EB; Mon, 13 May 2024 11:31:46 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 13 May 2024 11:31:09 +0200 Message-Id: From: "Gabriel Goller" To: "Christian Ebner" , "Proxmox Backup Server development discussion" X-Mailer: aerc 0.17.0-91-g65332c233880-dirty References: <20240503142933.171798-1-g.goller@proxmox.com> In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] config: add default datastore creation function X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Mon May 13, 2024 at 10:52 AM CEST, Christian Ebner wrote: > On 5/3/24 16:29, Gabriel Goller wrote: > > Add a function to create a default datastore. This datastore will have a > > default prune-job with a daily schedule and a gc-job with a daily > > schedule as well. > > > > Tested this and found that while the default prune and > garbage-collection jobs are created when creating the datastore via the > WebUI or as part of a disk create transaction, this is not true if done > via the CLI or API for the datastore create itself, by e.g. > `proxmox-backup-manager datastore create `. This was intended. I talked about this with Stefan Lendl as well when he wrote the patches. I think the idea was to create the default jobs when creating a datastore through the ui (thus my patches above), but create a bare datastore (without any jobs) when using the cli. Obviously this is not so consistent. > Also, this default behavior should be documented. Absolutely. > > So similar to what Fabian already commented to patches from my side: > https://lists.proxmox.com/pipermail/pbs-devel/2023-November/007361.html Yes, fabian also mentioned the crucial point: when creating a datastore through the ui, you have the option to *not* create the default prune/gc jobs. In my patch series above you cannot do that because it's done on the api side. IMO I would discard my series here... I don't even know if adding a button to the ui 'create default jobs' or something like that would even be beneficial or just clutter the interface. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel