From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5C6DA1FF389 for ; Tue, 7 May 2024 16:11:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7BDF6F8BF; Tue, 7 May 2024 16:11:57 +0200 (CEST) Mime-Version: 1.0 Date: Tue, 07 May 2024 16:11:24 +0200 Message-Id: To: "Proxmox Backup Server development discussion" From: "Max Carrara" X-Mailer: aerc 0.17.0-72-g6a84f1331f1c References: <20240507081304.29656-1-g.goller@proxmox.com> In-Reply-To: <20240507081304.29656-1-g.goller@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #5422: ui: make columns in gcview sortable X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Tue May 7, 2024 at 10:13 AM CEST, Gabriel Goller wrote: > These columns were not sortable for some reason. Tested it as well and > the sorting seems to work fine. > > Signed-off-by: Gabriel Goller LGTM Reviewed-by: Max Carrara Tested-by: Max Carrara > --- > www/config/GCView.js | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/www/config/GCView.js b/www/config/GCView.js > index bcea72a5..1c9288e4 100644 > --- a/www/config/GCView.js > +++ b/www/config/GCView.js > @@ -164,7 +164,7 @@ Ext.define('PBS.config.GCJobView', { > { > header: gettext('Schedule'), > dataIndex: 'schedule', > - sortable: false, > + sortable: true, > hideable: false, > renderer: (value) => value ? value : Proxmox.Utils.NoneText, > minWidth: 85, > @@ -182,7 +182,7 @@ Ext.define('PBS.config.GCJobView', { > text: gettext('Duration'), > dataIndex: 'duration', > renderer: Proxmox.Utils.render_duration, > - sortable: false, > + sortable: true, > minWidth: 80, > flex: 1, > }, > @@ -207,7 +207,7 @@ Ext.define('PBS.config.GCJobView', { > dataIndex: 'removed-bytes', > renderer: (value, meta, record) => record.data.upid !== null > ? Proxmox.Utils.format_size(value, true) : "-", > - sortable: false, > + sortable: true, > minWidth: 85, > flex: 1, > }, > @@ -216,7 +216,7 @@ Ext.define('PBS.config.GCJobView', { > dataIndex: 'pending-bytes', > renderer: (value, meta, record) => record.data.upid !== null > ? Proxmox.Utils.format_size(value, true) : "-", > - sortable: false, > + sortable: true, > minWidth: 80, > flex: 3, > }, _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel