From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7EE6C20EC91 for ; Tue, 30 Apr 2024 12:11:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 01F45310CB; Tue, 30 Apr 2024 12:11:49 +0200 (CEST) Mime-Version: 1.0 Date: Tue, 30 Apr 2024 12:11:44 +0200 Message-Id: To: "Thomas Lamprecht" , "Proxmox Backup Server development discussion" From: "Gabriel Goller" X-Mailer: aerc 0.17.0-91-g65332c233880-dirty References: <20240426140246.168397-1-g.goller@proxmox.com> <20240426140246.168397-2-g.goller@proxmox.com> <7685e590-6730-4450-9cc2-a75cbc9aed61@proxmox.com> In-Reply-To: <7685e590-6730-4450-9cc2-a75cbc9aed61@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] applied: [PATCH proxmox v3 1/2] metrics: encode influxdb org and bucket parameters X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Fri Apr 26, 2024 at 5:52 PM CEST, Thomas Lamprecht wrote: > Am 26/04/2024 um 16:02 schrieb Gabriel Goller: > > In order to remove the current limitations on the bucket and > > organization names, we need to make sure that they are transmitted > > correctly. In order to do this, we encode them using the url crate. > > > > This way we support organization/bucket names that include slashes, > > whitespaces, etc. > > > > Signed-off-by: Gabriel Goller > > --- > > proxmox-metrics/Cargo.toml | 1 + > > proxmox-metrics/src/influxdb/http.rs | 7 ++++++- > > 2 files changed, 7 insertions(+), 1 deletion(-) > > > > > > applied, thanks! > > Having some tests here might be nice though. E.g., moving the URI assembly > into a separate method and having either a test module or doc-tests to > ensure that some common and odd cases, e.g. those requiring encoding, are > handled correctly. Sent a follow-up to the list! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel