From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 801741FF56B for ; Mon, 22 Apr 2024 09:59:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3AE83A708; Mon, 22 Apr 2024 09:59:34 +0200 (CEST) Mime-Version: 1.0 Date: Mon, 22 Apr 2024 09:59:00 +0200 Message-Id: From: "Gabriel Goller" To: "Thomas Lamprecht" , "Proxmox Backup Server development discussion" X-Mailer: aerc 0.17.0-91-g65332c233880-dirty References: <20240419131804.245038-1-g.goller@proxmox.com> <7f1fa7cb-87ba-4f90-9763-08fa3e298285@proxmox.com> In-Reply-To: <7f1fa7cb-87ba-4f90-9763-08fa3e298285@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] api-types: remove influxdb name restrictions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Mon Apr 22, 2024 at 9:26 AM CEST, Thomas Lamprecht wrote: > Am 22/04/2024 um 09:20 schrieb Gabriel Goller: > > On Sun Apr 21, 2024 at 1:28 PM CEST, Thomas Lamprecht wrote: > >> for the subject please do s/name/bucket name/ as otherwise one might think > >> this is about the ID of an InfluxDB metric server. > > > > Will do. > > > >> Am 19/04/2024 um 15:18 schrieb Gabriel Goller: > >>> Remove the regex for influxdb organizations and buckets. Influxdb does > >>> not place any constraints on these names and allows all characters. This > >>> allows influxdb organization names with slashes. > >>> > >>> Also remove a duplicate comment and add some missing ones. > >> > >> > >> did you run into this or some user (forum link, bug report)? > > > > From a forum thread here (will also include this in the next patch): > > https://forum.proxmox.com/threads/influx-db-organization-doesnt-allow-slash.145402/ > > > >> What about Proxmox VE, that also has a InfluxDB > > > > In Proxmox VE there are no restrictions to bucket/organization names. > > > > OK, it would be nice to mention that here, because having the same schema > and behavior across products is a merit in itself. Thanks for the review! Submitted a v2. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel