From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <g.goller@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 0F2C996871
for <pbs-devel@lists.proxmox.com>; Tue, 16 Apr 2024 11:37:43 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E550B17272
for <pbs-devel@lists.proxmox.com>; Tue, 16 Apr 2024 11:37:12 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Tue, 16 Apr 2024 11:37:12 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2CA5A45433
for <pbs-devel@lists.proxmox.com>; Tue, 16 Apr 2024 11:37:12 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 16 Apr 2024 11:37:11 +0200
Message-Id: <D0LG2CV3ONM9.WM2AEAILP5GY@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
From: "Gabriel Goller" <g.goller@proxmox.com>
X-Mailer: aerc 0.17.0-91-g65332c233880-dirty
References: <20240412100631.94218-1-l.wagner@proxmox.com>
<20240412100631.94218-15-l.wagner@proxmox.com>
In-Reply-To: <20240412100631.94218-15-l.wagner@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.085 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 14/33] server: notifications:
send GC notifications via notification system
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2024 09:37:43 -0000
On Fri Apr 12, 2024 at 12:06 PM CEST, Lukas Wagner wrote:
> diff --git a/src/server/gc_job.rs b/src/server/gc_job.rs
> index 41375d72..ff5bdccf 100644
> --- a/src/server/gc_job.rs
> +++ b/src/server/gc_job.rs
> @@ -19,8 +19,6 @@ pub fn do_garbage_collection_job(
> ) -> Result<String, Error> {
> let store =3D datastore.name().to_string();
> =20
> - let (email, notify) =3D crate::server::lookup_datastore_notify_setti=
ngs(&store);
> -
> let worker_type =3D job.jobtype().to_string();
> let upid_str =3D WorkerTask::new_thread(
> &worker_type,
> @@ -43,11 +41,9 @@ pub fn do_garbage_collection_job(
> eprintln!("could not finish job state for {}: {err}", jo=
b.jobtype());
> }
> =20
> - if let Some(email) =3D email {
> - let gc_status =3D datastore.last_gc_status();
> - if let Err(err) =3D send_gc_status(&email, notify, &stor=
e, &gc_status, &result) {
> - eprintln!("send gc notification failed: {err}");
> - }
> + let gc_status =3D datastore.last_gc_status();
> + if let Err(err) =3D send_gc_status(&store, &gc_status, &resu=
lt) {
> + eprintln!("send gc notification failed: {err}");
I think we should use 'task_err!()' here. I know eprintln is used above,
and technically works because we redirect stderr in the service setup=20
but it's still slow and kinda the legacy method of printing task errors.
> }
> =20
> result