From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6B6719584E for ; Fri, 12 Apr 2024 15:59:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4B5A3B70A for ; Fri, 12 Apr 2024 15:59:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Apr 2024 15:59:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0BEA845089 for ; Fri, 12 Apr 2024 15:59:56 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 12 Apr 2024 15:59:55 +0200 Message-Id: From: "Gabriel Goller" To: "Proxmox Backup Server development discussion" X-Mailer: aerc 0.17.0-91-g65332c233880-dirty References: <20240412100631.94218-1-l.wagner@proxmox.com> In-Reply-To: <20240412100631.94218-1-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.086 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 00/33] integrate notification system X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2024 13:59:57 -0000 First of all, thanks for implementing this! I can't count how many times I've seen a forum post asking for better notifications in pbs! Some high-level comments: - The 'hostname' field doesn't make any sense in pbs (AFAICT) because there is only one node. - The 'type' field could have hardcoded values, such as 'gc', 'verify', etc. this way we can also have a drop-down menu in the ui. This makes it a lot easier than checking the docs/guessing. - A notification when a backup succeeds/fails would be very useful as well. - Also having datastore and namespace filters on the notification matchers would be great (if feasible obv.). Another thing I noticed is that creating a datastore through the cli=20 still uses the legacy notification system. Will make a more in depth review next week!