From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <m.carrara@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A97C193A7A for <pbs-devel@lists.proxmox.com>; Tue, 9 Apr 2024 15:20:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B7D01EE87 for <pbs-devel@lists.proxmox.com>; Tue, 9 Apr 2024 15:20:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Tue, 9 Apr 2024 15:20:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2B0E84179C for <pbs-devel@lists.proxmox.com>; Tue, 9 Apr 2024 15:20:03 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 09 Apr 2024 15:20:02 +0200 Message-Id: <D0FMF638P7ZW.B137XVO7TODT@proxmox.com> To: "Proxmox Backup Server development discussion" <pbs-devel@lists.proxmox.com> From: "Max Carrara" <m.carrara@proxmox.com> X-Mailer: aerc 0.17.0-72-g6a84f1331f1c References: <20240409121423.168627-1-f.schauer@proxmox.com> In-Reply-To: <20240409121423.168627-1-f.schauer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v7 vma-to-pbs 0/9] Implement vma-to-pbs tool X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 09 Apr 2024 13:20:35 -0000 On Tue Apr 9, 2024 at 2:14 PM CEST, Filip Schauer wrote: > Implement a tool to import VMA files into a Proxmox Backup Server > > Example usage: > > zstd -d --stdout vzdump.vma.zst | vma-to-pbs \ > --repository <auth_id@host:port:datastore> \ > --vmid 123 \ > --password-file pbs_password > > Changes since v6: > * Move bail! in VmaReader::restore to the commit it was introduced in > * Move the use of anyhow::Context for fingerprint argument matching to > the commit it was introduced in > * Use proxmox_time::epoch_to_rfc3339 for formatting backup_time > * Refactor elapsed time calculation for better readability > * Bump proxmox-backup-qemu in order to get access to ProxmoxBackupHandle > * use anyhow::format_err > * Move introduction of handle_pbs_error to the commit that introduced > vma2pbs. > * Use anyhow::Error with std::result::Result instead of anyhow::Result I've read all the patches and also tested the CLI again with a couple .vma.zst files. Everything seems to work flawlessly. This came a long way - very nice job! :) I know this series got applied already, but FWIW: Reviewed-by: Max Carrara <m.carrara@proxmox.com> Tested-by: Max Carrara <m.carrara@proxmox.com>