From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 85A2893ABD for ; Tue, 9 Apr 2024 15:06:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5DCAB1E8BA for ; Tue, 9 Apr 2024 15:06:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 9 Apr 2024 15:06:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6FC564092A for ; Tue, 9 Apr 2024 15:06:11 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 09 Apr 2024 15:06:10 +0200 Message-Id: To: "Proxmox Backup Server development discussion" From: "Max Carrara" X-Mailer: aerc 0.17.0-72-g6a84f1331f1c References: <20240403094913.107177-1-f.schauer@proxmox.com> <20240403094913.107177-5-f.schauer@proxmox.com> <3e418de5-0919-4e6c-905b-79e6bb1c2dbb@proxmox.com> In-Reply-To: <3e418de5-0919-4e6c-905b-79e6bb1c2dbb@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH vma-to-pbs 4/9] add support for streaming the VMA file via stdin X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2024 13:06:42 -0000 On Tue Apr 9, 2024 at 2:16 PM CEST, Filip Schauer wrote: > On 03/04/2024 16:52, Max Carrara wrote: > >> + let elapsed_ms =3D SystemTime::now() > >> + .duration_since(start_transfer_time)? > >> + .as_millis(); > >> + println!( > >> + "Backup finished within {} minutes, {} seconds and {} ms", > >> + elapsed_ms / 1000000, > >> + (elapsed_ms / 1000) % 60, > >> + elapsed_ms % 1000 > >> + ); > > The seconds are not calculated correctly here: 1s =3D 60_000ms > > > > To make it less error prone, you could just use seconds by default and > > milliseconds where necessary, e.g.: > > > > let total_seconds =3D duration.as_secs(); > > > > let minutes =3D total_seconds / 60; > > let seconds =3D total_seconds % 60; > > let milliseconds =3D duration.as_millis() % 1000; > > I don't see what about my seconds calculation is wrong, but I adapted > the code anyway to make it less confusing. My bad! I phrased that incorrectly; I meant that 1 minute =3D 60_000ms. Sorry for the confusion! > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel