From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 14C46BAFE8 for ; Fri, 22 Mar 2024 14:53:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E29A96E02 for ; Fri, 22 Mar 2024 14:52:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 22 Mar 2024 14:52:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1927541AAB for ; Fri, 22 Mar 2024 14:52:43 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 22 Mar 2024 14:52:41 +0100 Message-Id: To: "Proxmox Backup Server development discussion" From: "Gabriel Goller" X-Mailer: aerc 0.17.0-37-g3aa8b6308482-dirty References: <20240304132618.91099-1-h.laimer@proxmox.com> In-Reply-To: <20240304132618.91099-1-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.093 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] datastore: remove datastore from internal cache based on maintenance mode X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2024 13:53:14 -0000 On Mon Mar 4, 2024 at 2:26 PM CET, Hannes Laimer wrote: > We keep a DataStore cache, so ChunkStore's and lock files are kept by > the proxy process and don't have to be reopened every time. However, for > specific maintenance modes, e.g. 'offline', our process should not keep > file in that datastore open. This clears the cache entry of a datastore > if it is in a specific maintanance mode and the last task finished, which > also drops any files still open by the process. > > Signed-off-by: Hannes Laimer The code looks good and clippy/fmt doesn't throw any errors! Also tested this thoroughly and it works perfectly. Consider: Reviewed-by: Gabriel Goller Tested-by: Gabriel Goller