From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <g.goller@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id B4064B9650
 for <pbs-devel@lists.proxmox.com>; Thu, 14 Mar 2024 10:11:03 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 94BD39589
 for <pbs-devel@lists.proxmox.com>; Thu, 14 Mar 2024 10:11:03 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Thu, 14 Mar 2024 10:10:59 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 204A8489CA
 for <pbs-devel@lists.proxmox.com>; Thu, 14 Mar 2024 10:10:59 +0100 (CET)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 14 Mar 2024 10:10:58 +0100
Message-Id: <CZTCUB1LXTKH.24YIFIGOXIMX3@proxmox.com>
From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, "Proxmox Backup Server
 development discussion" <pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.17.0-37-g3aa8b6308482-dirty
References: <20240313161801.132483-1-g.goller@proxmox.com>
 <20240313161801.132483-2-g.goller@proxmox.com>
 <f463e77b-2285-4037-8567-efac001b33e7@proxmox.com>
In-Reply-To: <f463e77b-2285-4037-8567-efac001b33e7@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.091 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] fix #5188: gui: add copy
 to clipboard on snapshots
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 14 Mar 2024 09:11:03 -0000

On Thu Mar 14, 2024 at 9:01 AM CET, Dominik Csapak wrote:
> same comment as the previous patch, some note about why async is
> ok would be nice
>
> one high level comment:
>
> i'd probably rename the button from 'copy' to something like 'copy name t=
o clipboard'
>=20
> otherwise it can be confusing as to what the button does, since 'copy' co=
uld
> also mean duplicate the snapshot ;)

I agree, will rename it in v2.

> rest of the patch LGTM

Thanks for the review!