From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D244CB90DD for ; Tue, 12 Mar 2024 14:08:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A97D317F0F for ; Tue, 12 Mar 2024 14:07:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 12 Mar 2024 14:07:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8CF1F43E29 for ; Tue, 12 Mar 2024 14:07:28 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 12 Mar 2024 14:07:27 +0100 Message-Id: From: "Gabriel Goller" To: "Proxmox Backup Server development discussion" X-Mailer: aerc 0.17.0-37-g3aa8b6308482-dirty References: <20240308133625.32282-1-g.goller@proxmox.com> <87a5n32143.fsf@gmail.com> In-Reply-To: <87a5n32143.fsf@gmail.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.092 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] api: make prune-group a real workertask X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2024 13:08:00 -0000 On Tue Mar 12, 2024 at 11:30 AM CET, Stefan Lendl wrote: > > LGTM with a slight note below for a style preference. > > > + let prune_group =3D move |worker: Arc| { > > + if keep_all { > > + task_log!(worker, "No prune selection - keeping all files.= "); > > + } else { > > You don't actually need to spawn a task if you're not doing any work. > On the other hand it makes the code slightly simpler and you need the > worker, right? IMO starting a worker is better, because the user sees that something is happening... I mean we could also immediately return and show a popup in the frontend, but that won't work when the user isn't logged in/currently looking at the page. This way he simply sees a prune job in the task log which prints 'No prune selection - keeping all files'. > > [snip] > > - for (info, mark) in prune_info { > > - let keep =3D keep_all || mark.keep(); > > > + for (info, mark) in prune_info { > > + let keep =3D keep_all || mark.keep(); > > + let backup_dir =3D &info.backup_dir; > > You wouldn't have to handle keep_all here. > > You're handling dry_run separatly already as well. Hmm I think I need it here though, note that this is not inside the if/else statement above. Even if we have keep_all we still want to go through all the snapshots and mark them (+ output mark) I guess. Thanks for the review!