From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E13A194C9A for ; Fri, 23 Feb 2024 10:27:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C8626152B7 for ; Fri, 23 Feb 2024 10:26:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 23 Feb 2024 10:26:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1866644EB6 for ; Fri, 23 Feb 2024 10:26:33 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 23 Feb 2024 10:26:32 +0100 Message-Id: From: "Stefan Sterz" To: "Proxmox Backup Server development discussion" X-Mailer: aerc 0.17.0-57-g782a17dfb056 References: <20240215152001.269490-1-s.sterz@proxmox.com> <20240215152001.269490-11-s.sterz@proxmox.com> <0434cd4f-d0fe-4c1d-9d70-fbf7bac4f239@proxmox.com> In-Reply-To: <0434cd4f-d0fe-4c1d-9d70-fbf7bac4f239@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 10/12] auth: upgrade hashes on user log in X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2024 09:27:03 -0000 On Mon Feb 19, 2024 at 7:58 PM CET, Max Carrara wrote: > On 2/15/24 16:19, Stefan Sterz wrote: -- >8 snip 8< -- > > + // if the password hash is not based on the curren= t hashing function (as > > + // identified by its prefix), rehash the password. > > + if !enc_password.starts_with(proxmox_sys::crypt::H= ASH_PREFIX) { > > + // ignore errors here, we already authenticate= d the user, re-hashing the > > + // password should not prevent them from loggi= ng in. > > + let _ =3D self.store_password(username, passwo= rd, client_ip); > > IMO this should be logged somewhere instead of just swallowing the > error silently, possibly even warning the user or admin that re-hashing > failed (while letting them log on anyways). > > The point of this series is to move away from the old stuff, so we > should ensure that we actually do. > makes sense to log this, but warning the users is probably not all that useful. most users won't be able to do anything about the warning (with exception of admins who should watch the logs anyway) and it is probably more confusing than helpful. -- >8 snip 8< --