From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <g.goller@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 6F60C931E5
 for <pbs-devel@lists.proxmox.com>; Mon, 19 Feb 2024 11:54:20 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 48B291DCCA
 for <pbs-devel@lists.proxmox.com>; Mon, 19 Feb 2024 11:53:50 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Mon, 19 Feb 2024 11:53:49 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 77562437EF
 for <pbs-devel@lists.proxmox.com>; Mon, 19 Feb 2024 11:53:49 +0100 (CET)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 19 Feb 2024 11:53:48 +0100
Message-Id: <CZ8ZZYYOUWPK.2M6MNWHGAJNXG@proxmox.com>
From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Proxmox Backup Server development discussion"
 <pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.17.0-37-g3aa8b6308482-dirty
References: <20240216153317.323260-1-g.goller@proxmox.com>
 <20240216153317.323260-5-g.goller@proxmox.com>
 <e3fee3e7-697a-496f-93a7-02d0e3121ebd@proxmox.com>
In-Reply-To: <e3fee3e7-697a-496f-93a7-02d0e3121ebd@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.100 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pbs-devel] [PATCH proxmox-backup 4/4] pxar: use anyhow::Error
 in PxarBackupStream
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 19 Feb 2024 10:54:20 -0000

On Fri Feb 16, 2024 at 6:47 PM CET, Max Carrara wrote:
> On 2/16/24 16:33, Gabriel Goller wrote:
> > +            let mut error =3D self.error.lock().unwrap();
> > +            if error.is_some() {
> > +                let err =3D error.take().unwrap();
> > +                return Poll::Ready(Some(Err(err)));
> >              }
>
> ... could be replaced with the following:
>
>     let mut error =3D self.error.lock().unwrap();
>     if let Some(err) =3D error.take() {
>         return Poll::Ready(Some(Err(err)));
>     }
>
> `Option::take()` also returns an `Option`, allowing you to omit the `unwr=
ap()`.

Good point!
Will be fixed in the next version!