From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <g.goller@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 9828D93631
 for <pbs-devel@lists.proxmox.com>; Mon,  5 Feb 2024 14:50:38 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 8173B1833D
 for <pbs-devel@lists.proxmox.com>; Mon,  5 Feb 2024 14:50:38 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Mon,  5 Feb 2024 14:50:37 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 92DF844231
 for <pbs-devel@lists.proxmox.com>; Mon,  5 Feb 2024 14:50:37 +0100 (CET)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 05 Feb 2024 14:50:36 +0100
Message-Id: <CYX6ZPOQU2XA.7DORR7BYGXAV@proxmox.com>
From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Proxmox Backup Server development discussion"
 <pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.16.0-149-g2d8b81f619fc
References: <20240205115830.523721-2-s.lendl@proxmox.com>
 <20240205115830.523721-5-s.lendl@proxmox.com>
In-Reply-To: <20240205115830.523721-5-s.lendl@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -1.422 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 ENA_SUBJ_ODD_CASE         2.6 Subject has odd case
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/8] prune: use NoneText as
 emptyValue in PruneJobEdit
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 05 Feb 2024 13:50:38 -0000

On Mon Feb 5, 2024 at 12:58 PM CET, Stefan Lendl wrote:
> Display None value as presented in Proxmox.Utils.NoneText.
> Make this identical to other uses where a None value is displayed
>
> Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
> ---
>  www/window/PruneJobEdit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
> index 84159a9d..fa4fc149 100644
> --- a/www/window/PruneJobEdit.js
> +++ b/www/window/PruneJobEdit.js
> @@ -114,7 +114,7 @@ Ext.define('PBS.window.PruneJobEdit', {
>  		fieldLabel: gettext('Prune Schedule'),
>  		xtype: 'pbsCalendarEvent',
>  		name: 'schedule',
> -		emptyText: gettext('none (disabled)'),
> +		emptyText: gettext(Proxmox.Utils.NoneText + " (disabled)"),
>  		cbind: {
>  			deleteEmpty: '{!isCreate}',
>  			value: '{scheduleValue}',

Hmm, the schedule value here is not optional, so adding `(disabled)` is
kind of misleading... I think it's better to remove `emptyText` and add
a `allowBlank: false` here.