From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7953F90E58 for ; Mon, 2 Oct 2023 13:14:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 53D9816A30 for ; Mon, 2 Oct 2023 13:13:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 2 Oct 2023 13:13:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A13BB48EE7 for ; Mon, 2 Oct 2023 13:13:51 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Mon, 02 Oct 2023 13:13:50 +0200 From: "Lukas Wagner" To: "Proxmox Backup Server development discussion" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-Id: X-Mailer: aerc 0.14.0 References: <20231002083811.323890-1-p.hufnagl@proxmox.com> In-Reply-To: <20231002083811.323890-1-p.hufnagl@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] ui: fix #4260: add dynamic notes in backup group comment X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2023 11:14:23 -0000 On Mon Oct 2, 2023 at 10:38 AM CEST, Philipp Hufnagl wrote: > - if (v =3D=3D=3D undefined || v =3D=3D=3D null) { > - v =3D ''; > + > + let additional_classes =3D ""; Note: I know the codebase is in some parts inconsistent in that regard, but for new code please use camelCase for variables and functions [1]. [1] https://pve.proxmox.com/wiki/Javascript_Style_Guide Apart from that, the changes look fine and work as advertised. Tested-by: Lukas Wagner