From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <l.wagner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 24A32B483
 for <pbs-devel@lists.proxmox.com>; Wed,  9 Aug 2023 12:12:39 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 0CD531353A
 for <pbs-devel@lists.proxmox.com>; Wed,  9 Aug 2023 12:12:39 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Wed,  9 Aug 2023 12:12:38 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4FF6243358
 for <pbs-devel@lists.proxmox.com>; Wed,  9 Aug 2023 12:12:38 +0200 (CEST)
Content-Type: text/plain; charset=UTF-8
Date: Wed, 09 Aug 2023 12:12:37 +0200
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Backup Server development discussion"
 <pbs-devel@lists.proxmox.com>, <c.heiss@proxmox.com>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Message-Id: <CUNXKGBW2TB9.HXSH4O00RWC1@pali>
X-Mailer: aerc 0.14.0
References: <20230808122239.1025524-1-c.heiss@proxmox.com>
 <20230808122239.1025524-10-c.heiss@proxmox.com>
In-Reply-To: <20230808122239.1025524-10-c.heiss@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.039 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 09/12] realm sync: add sync
 job for AD realms
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 09 Aug 2023 10:12:39 -0000

On Tue Aug 8, 2023 at 2:22 PM CEST, Christoph Heiss wrote:
>  use crate::server::jobstate::Job;
> @@ -102,6 +103,7 @@ pub fn sync_realm(
>      let upid_str =3D crate::server::do_realm_sync_job(
>          job,
>          realm.clone(),
> +        realm_type_from_name(&*realm)?,
^ Clippy: warning: deref which would be done by auto-deref, change to
`&realm`