From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BC9596693F for ; Fri, 6 Nov 2020 18:24:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AC96724AC9 for ; Fri, 6 Nov 2020 18:24:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 917B124AB9 for ; Fri, 6 Nov 2020 18:24:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5E8874605B for ; Fri, 6 Nov 2020 18:24:15 +0100 (CET) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20201106100343.12161-1-d.csapak@proxmox.com> <20201106100343.12161-3-d.csapak@proxmox.com> From: Thomas Lamprecht Message-ID: <9f89bd33-1afb-fd68-3333-25f53c4210b0@proxmox.com> Date: Fri, 6 Nov 2020 18:24:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201106100343.12161-3-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.113 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [fs.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/6] tools/fs: add helpers to get the mtime of a file X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 17:24:16 -0000 On 06.11.20 11:03, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > src/tools/fs.rs | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/src/tools/fs.rs b/src/tools/fs.rs > index 72a530d8..d7ab934a 100644 > --- a/src/tools/fs.rs > +++ b/src/tools/fs.rs > @@ -312,3 +312,25 @@ fn do_lock_dir_noblock( > > Ok(handle) > } > + > +pub fn get_file_mtime>(path: P) -> Result { > + let time = std::fs::metadata(path)?.modified()?; > + > + let mtime: i64 = if time < std::time::SystemTime::UNIX_EPOCH { > + -(std::time::SystemTime::UNIX_EPOCH.duration_since(time)?.as_secs() as i64) > + } else { > + time.duration_since(std::time::SystemTime::UNIX_EPOCH)?.as_secs() as i64 > + }; > + Ok(mtime) > +} > + > +pub async fn get_async_file_mtime>(path: P) -> Result { > + let time = tokio::fs::metadata(path).await?.modified()?; > + > + let mtime: i64 = if time < std::time::SystemTime::UNIX_EPOCH { > + -(std::time::SystemTime::UNIX_EPOCH.duration_since(time)?.as_secs() as i64) > + } else { > + time.duration_since(std::time::SystemTime::UNIX_EPOCH)?.as_secs() as i64 > + }; > + Ok(mtime) > +} > wouldn't it be more sensible to implement just a system_time_to_i64 and use that in combination with a "manual" modified call on use-site. Avoids instancing multiple generics, and more flexible as one can have a file handle or a path.