From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 07CD81FF179 for ; Wed, 12 Nov 2025 13:06:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 613B3190D; Wed, 12 Nov 2025 13:07:19 +0100 (CET) Message-ID: <9f6ce3dc-5134-407f-bbad-d70324df9416@proxmox.com> Date: Wed, 12 Nov 2025 13:06:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20251029160103.241780-1-h.laimer@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20251029160103.241780-1-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762949180484 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] superseded: [PATCH proxmox{, -backup} v2 0/5] unmount datastores after sync job X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" superseded-by: https://lore.proxmox.com/pbs-devel/20251112120515.145480-1-h.laimer@proxmox.com/T/#t On 10/29/25 17:01, Hannes Laimer wrote: > Adds the option to automatically unmount a datastore after a sync job > finishes. > > The idea is that, in combination with run-on-mount, it is possible to > have datastores sync to external drives without the need to open the web > ui or terminal. This came up a handful of times in support and a recent > thread on the forum. Basically, also non-tech people could be tasked > with plugging and unplugging different drives regularly and mounting, > sync and unmounting would be done automatically. > > Currently if any of the triggered jobs have the 'unmount-on-done' flag > set the datastore will be unmounted right after the last of the > triggered jobs finishes. > > This seemed pretty straight forward and should be good in most use-cases > I came up with. Also, I did consider having 'unmount-on-done' also for > normally(schedule/manual) started jobs, I guess there could be some > situations where that might useful. But, as I mentioned on the commit > itself, we'd probably have to go through the command socket since sync jobs run > on the proxy. And I did not think it adds that much, also not sure if > we'd even want that. > > Tested-by: Robert Obkircher > > v2, thanks @Robert and @Shannon > - include short docs section > - fix typo > - fix test > - use `|=` (instead of `= ... || ...`) > > proxmox: > > Hannes Laimer (1): > pbs-api-types: add 'unmount-on-done' field to sync job config > > pbs-api-types/src/jobs.rs | 8 ++++++++ > 1 file changed, 8 insertions(+) > > > proxmox-backup: > > Hannes Laimer (4): > api: syncjob: correctly update/delete 'unmount-on-done' field > api: datastore: unmount datastore after sync if configured > ui: add 'unmount-on-done' field to SyncJobEdit window > docs: add section about `unmount-on-done` > > docs/managing-remotes.rst | 4 ++++ > src/api2/admin/datastore.rs | 21 +++++++++++++++++++-- > src/api2/config/sync.rs | 9 +++++++++ > www/window/SyncJobEdit.js | 23 +++++++++++++++++++++++ > 4 files changed, 55 insertions(+), 2 deletions(-) > > > Summary over all repositories: > 5 files changed, 63 insertions(+), 2 deletions(-) > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel