From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9289A9D81F for ; Fri, 24 Nov 2023 11:38:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E115C803 for ; Fri, 24 Nov 2023 11:38:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 24 Nov 2023 11:38:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B00D043AED for ; Fri, 24 Nov 2023 11:38:12 +0100 (CET) Message-ID: <9e883884-7c6f-40e2-b5b1-d1165bb6a78d@proxmox.com> Date: Fri, 24 Nov 2023 11:38:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox Backup Server development discussion , Hannes Laimer References: <20231121143155.370916-1-h.laimer@proxmox.com> From: Lukas Wagner In-Reply-To: <20231121143155.370916-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v6 0/6] local sync-jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2023 10:38:43 -0000 On 11/21/23 15:31, Hannes Laimer wrote: > Add support for local sync. SyncJobs without a remote are considered local, and > use a different logic for pulling. In the course of adding the extra pull logic, > the pull code was rewritten to basically be source independent. Also cli > completion and the UI was updated to allow Remotes in SyncJobs to be optional. > Gave this another quick test on the latest master, LGTM. Quickly glanced over the code, didn't see anything bothersome there (three minor nits in the UI code, but no blockers) Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner -- - Lukas