From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 433041FF163 for ; Thu, 21 Nov 2024 17:15:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 20A1C1CD7; Thu, 21 Nov 2024 17:15:09 +0100 (CET) Message-ID: <9ccf5606-ff5a-4473-96b3-a9ea80ab0dcf@proxmox.com> Date: Thu, 21 Nov 2024 17:15:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= References: <20241031121519.434337-1-c.ebner@proxmox.com> <20241031121519.434337-13-c.ebner@proxmox.com> <173089427968.79072.3773251895934605531@yuna.proxmox.com> <56e5b937-448e-4aa7-b285-f5cbad777bcb@proxmox.com> <13127ac6-d634-4ba4-b48a-9866110e35e1@proxmox.com> <65ce8683-8e27-4d4e-a2f3-9d05960f2e72@proxmox.com> <6bf543a9-1d7c-412e-9862-40e42ddf005e@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <6bf543a9-1d7c-412e-9862-40e42ddf005e@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [swagger.io] Subject: Re: [pbs-devel] [PATCH v6 proxmox-backup 12/29] api/api-types: refactor api endpoint version, add api types X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 11/21/24 17:01, Thomas Lamprecht wrote: > Am 21.11.24 um 10:58 schrieb Christian Ebner: >> On 11/21/24 10:23, Thomas Lamprecht wrote: >> Well, that is something I did not consider at all! So with that >> viewpoint, adding this to PBS specifically is surely not the best way. >> As discussed with Fabain off list, version based matching will be the >> best way forward here, and dropping the incompatibility check once EOL >> is reached. > > If we add such a thing that you proposed we should definitively get the > story somewhat straight w.r.t. how we want to handle this for all projects, > and define when to define a feature and when not, with some extra care on > the interfaces, as those are relatively set in stone. Regarding this, have we considered exposing the API schema to the client, something like [0]? Fetching the remote API schema and therefore knowing which parameters are available would have not only covered the additional check, but also allowed to see what response value to expect. Although, I guess this boils down to the same set of maintenance burden in the end, hard to maintain code because of to many condition checks. [0] https://swagger.io/specification/ _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel