From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 114EC1FF164
for <inbox@lore.proxmox.com>; Fri, 4 Jul 2025 13:34:13 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 45F673666D;
Fri, 4 Jul 2025 13:34:54 +0200 (CEST)
Message-ID: <9cbe19d3-1bfb-41f8-a94d-4f8f110607b5@proxmox.com>
Date: Fri, 4 Jul 2025 13:34:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Hannes Laimer <h.laimer@proxmox.com>
References: <20250604123054.87007-1-h.laimer@proxmox.com>
<20250604123054.87007-7-h.laimer@proxmox.com>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <20250604123054.87007-7-h.laimer@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.040 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 6/7] ui: add run-on-mount
checkbox to SyncJob form
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On 6/4/25 14:30, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> www/window/SyncJobEdit.js | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index 4cef9a1d..73a489f1 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -195,7 +195,7 @@ Ext.define('PBS.window.SyncJobEdit', {
> xtype: 'pbsCalendarEvent',
> name: 'schedule',
> fieldLabel: gettext('Sync Schedule'),
> - emptyText: gettext('none (disabled)'),
> + emptyText: gettext('none'),
> cbind: {
> deleteEmpty: '{!isCreate}',
> value: '{scheduleValue}',
> @@ -451,6 +451,17 @@ Ext.define('PBS.window.SyncJobEdit', {
> uncheckedValue: false,
> value: false,
> },
> + {
> + xtype: 'proxmoxcheckbox',
> + name: 'run-on-mount',
> + fieldLabel: gettext('Run when mounted'),
> + autoEl: {
> + tag: 'div',
> + 'data-qtip': gettext('Run this job when a relevant removable datastore is mounted.'),
> + },
> + uncheckedValue: false,
> + value: false,
> + },
> ],
> },
> {
nit: pre-existing for other boolean flags here as well, but this should
make sure that it is set as `delete` value if set to it's default.
Otherwise this is not removed from the sync job config, but set to the
default instead. Removing it will help reduce the size of the config and
improve it's readability.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel