From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 51E8B1FF172 for ; Tue, 3 Sep 2024 08:55:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0456215CCD; Tue, 3 Sep 2024 08:55:43 +0200 (CEST) Message-ID: <9be18be1-f600-4292-bef7-559a2946a994@proxmox.com> Date: Tue, 3 Sep 2024 08:55:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Dietmar Maurer , Proxmox Backup Server development discussion References: <20240826140459.2550345-1-d.csapak@proxmox.com> <1329219679.22023.1725341175476@webmail.proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <1329219679.22023.1725341175476@webmail.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup] tape: fix read element status for some changers X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 9/3/24 07:26, Dietmar Maurer wrote: >> It seems some changers are setting the PVolTag/AVolTag flags in the >> ELEMENT STATUS page response, but don't include the actual fields then. >> To make it work with such changers, downgrade the errors to warnings, so >> we can continue to decode the remaining data. > > cant we simply check if there is remaining data in the reader? yes we could, but we have to do it outside the functions, because we don't have access to the reader there, only to something that implements `read` should i send a patch that checks the remaining size beforehand? _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel