From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4E475CE12 for ; Tue, 19 Sep 2023 15:39:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F7C4B453 for ; Tue, 19 Sep 2023 15:38:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 19 Sep 2023 15:38:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 66C2947FCD for ; Tue, 19 Sep 2023 15:38:33 +0200 (CEST) Message-ID: <98a51fd8-b120-4c70-af45-8b9c16882cc8@proxmox.com> Date: Tue, 19 Sep 2023 15:38:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Lukas Wagner To: Proxmox Backup Server development discussion , Hannes Laimer References: <20230915065457.352953-1-h.laimer@proxmox.com> <20230915065457.352953-17-h.laimer@proxmox.com> Content-Language: de-AT, en-US In-Reply-To: <20230915065457.352953-17-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 16/23] ui: utils: make parseMaintenanceMode more robust X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2023 13:39:04 -0000 On 9/15/23 08:54, Hannes Laimer wrote: > - // FIXME: this "parser" is brittle and relies on the order the arguments will appear in > parseMaintenanceMode: function(mode) { > - let [type, message] = mode.split(/,(.+)/); > - type = type.split("=").pop(); > - message = message ? message.split("=")[1] > - .replace(/^"(.*)"$/, '$1') > - .replaceAll('\\"', '"') : null; > - return [type, message]; > + if (!mode) { > + return [null, null]; > + } > + return mode.split(',').reduce(([m, msg], pair) => { > + const [key, value] = pair.split('='); > + if (key === 'message') { > + return [m, value.replace(/^"(.*)"$/, '$1').replace(/\\"/g, '"')]; > + } else { > + return [value ?? key, msg]; > + } > + }, [null, null]); > }, > > renderMaintenance: function(mode, activeTasks) { I know, we don't really do this so far our code base, but for functions like these it would certainly be nice to document any function contracts (input format, function outputs, side effects). It's quite hard to review the code for correctness if this information is not provided. What do you think? -- - Lukas