From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A4D56C5DD for ; Mon, 11 Apr 2022 12:03:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 92DFE2EBA for ; Mon, 11 Apr 2022 12:03:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 00A822E9F for ; Mon, 11 Apr 2022 12:03:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C349040843 for ; Mon, 11 Apr 2022 12:03:13 +0200 (CEST) Message-ID: <95da5ac9-95ba-7e90-03be-00f38ce00415@proxmox.com> Date: Mon, 11 Apr 2022 12:03:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20220323130111.2552347-1-m.heiserer@proxmox.com> <20220323130111.2552347-3-m.heiserer@proxmox.com> <94299fed-fecf-e43a-6acb-c93db48998b6@proxmox.com> From: Matthias Heiserer In-Reply-To: <94299fed-fecf-e43a-6acb-c93db48998b6@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.474 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.086 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/3] fix #3939: ui: default realm setting in NodeOptionView X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2022 10:03:44 -0000 On 11.04.2022 10:13, Thomas Lamprecht wrote: > On 23.03.22 14:01, Matthias Heiserer wrote: >> Again, different than we do it in PVE, because default-realm >> is stored in node.cfg. >> > > While this patch may be obsolete in the current form with my bz comment and > review on the backend, still some notes. > >> Signed-off-by: Matthias Heiserer >> --- >> www/config/NodeOptionView.js | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/www/config/NodeOptionView.js b/www/config/NodeOptionView.js >> index bb12513b..f3652a53 100644 >> --- a/www/config/NodeOptionView.js >> +++ b/www/config/NodeOptionView.js >> @@ -53,8 +53,31 @@ Ext.define('PBS.NodeOptionView', { >> }, >> ], >> >> + add_pmxRealmComboBox_row: function(name, text, opts) { > > I'd figure that camels and snakes don't mix well, at least in casing style ;-) > > But in general: this is unnecessary, as currently used you can just add another > static entry in the `gridRows` array, and if the user of this whole component > needs to be able to config something (which they ain't with your approach, but > it feels like that was the aim?) a simple (c)bind can avoid such intermediate > creation helper. I don't think I can drop this function, because for each row entry the ObjectGrid searches for a function named `add_${rowdef.xtype}_row` and throws an error if none can be found. That's also the reason for the strange name. Maybe I misunderstand something? > >> + let me = this; >> + opts = opts || {}; >> + me.rows = me.rows || {}; >> + me.rows[name] = { >> + required: true, >> + header: text, >> + defaultValue: opts.defaultValue, >> + renderer: opts.renderer, >> + editor: { >> + xtype: 'proxmoxWindowEdit', >> + subject: text, >> + items: { >> + xtype: 'pmxRealmComboBox', >> + name: name, >> + }, >> + }, >> + }; >> + }, >> + >> initComponent: function() { >> let me = this; >> + me.add_pmxRealmComboBox_row('default-realm', gettext('Default realm'), { This call is unnecessary, I should put it in gridRows. >> + defaultValue: 'pam', >> + }); >> >> me.callParent(); >> >