From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0BA637068E for ; Fri, 3 Jun 2022 11:25:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 034BB5FC0 for ; Fri, 3 Jun 2022 11:25:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0390B5FB3 for ; Fri, 3 Jun 2022 11:25:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D12B04320E for ; Fri, 3 Jun 2022 11:25:37 +0200 (CEST) Message-ID: <94d813c2-2443-0cb5-3400-e054e0909365@proxmox.com> Date: Fri, 3 Jun 2022 11:25:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Thunderbird/101.0 Content-Language: en-GB To: Proxmox Backup Server development discussion , Dominik Csapak References: <20220602142744.548757-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220602142744.548757-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.007 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup] pbs-datastore: lookup: don't create new ChunkStore on datastore reopen X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2022 09:25:40 -0000 Am 02/06/2022 um 16:27 schrieb Dominik Csapak: > When re-opening a datastore, e.g. because the config changed or the > last re-open was >60s ago, the chunkstore was also re-opened. Opening a > ChunkStore creates a new ProcessLocker, so re-opening a datastore had the > unintentional side-effect of potentially discarding the existing > ProcessLocker. Any contained shared locks are lost in turn. > > To fix this, reuse an old, existing ChunkStore (and its ProcessLocker) > on the re-opened datastore, since only the datastore config should be > reloaded, and the ChunkStore path is not updatable over our API anyway. > If a user manually edited the path in the config, a daemon restart must > happen for this change to take effect. > > Signed-off-by: Dominik Csapak > --- > pbs-datastore/src/datastore.rs | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > forgot to reply yesterday: applied and backported, thanks!