From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B95FC75274 for ; Mon, 12 Jul 2021 06:23:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A980A107AB for ; Mon, 12 Jul 2021 06:23:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4002C1079D for ; Mon, 12 Jul 2021 06:23:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 111FA40EDF for ; Mon, 12 Jul 2021 06:23:28 +0200 (CEST) Message-ID: <94749d24-a501-2718-cf42-a6c42577b49a@proxmox.com> Date: Mon, 12 Jul 2021 06:23:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210618092910.4518-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210618092910.4518-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.474 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 1/2] backup/datastore: refactor chunk inode sorting to the datastore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2021 04:23:58 -0000 On 18.06.21 11:29, Dominik Csapak wrote: > so that we can reuse that information > > the removal of the adding to the corrupted list is ok, since > 'get_chunks_in_order' returns them at the end of the list > and we do the same if the loading fails later in 'verify_index_chunks' > so we still mark them corrupt > (assuming that the load will fail if the stat does) > > Signed-off-by: Dominik Csapak > --- > alternatively, we could return 2 lists, or check after the loop > for the u64::MAX value, but imho it's ok this way > > src/backup/datastore.rs | 38 ++++++++++++++++++++++++++++++++++++++ > src/backup/verify.rs | 38 +++++++------------------------------- > 2 files changed, 45 insertions(+), 31 deletions(-) > > Just for the record, as Dietmar applied this on "Mon Jun 28 12:16:14 2021 +0200", but I saw no applied mail and as you also still thought this was not in I figured it'll save me some time in the future if I record that: applied, thanks!