From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ED565B853A for ; Mon, 4 Dec 2023 17:10:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CABDE10C76 for ; Mon, 4 Dec 2023 17:09:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 4 Dec 2023 17:09:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7E600448E4 for ; Mon, 4 Dec 2023 17:09:55 +0100 (CET) Date: Mon, 4 Dec 2023 17:09:54 +0100 (CET) From: Christian Ebner To: Gabriel Goller , Proxmox Backup Server development discussion Message-ID: <93719761.451.1701706194804@webmail.proxmox.com> In-Reply-To: <1d497261-271e-4a07-8f79-3ef1e8508f77@proxmox.com> References: <20231130140104.378248-1-c.ebner@proxmox.com> <1d497261-271e-4a07-8f79-3ef1e8508f77@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev55 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: warn of missing gc-schedule, prune/verify jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2023 16:10:27 -0000 > On 04.12.2023 16:42 CET Gabriel Goller wrote: > > Small typo here... This should say `gcScheduleMsg`. Ah yes, thanks for noticing, will be fixed in a new version. > How about we put a green checkmark here (and on the other lines below)? > Otherwise this wall of text looks kinda bleak :( > We could add the `fa fa-check-circle` icon with the `good` (color: > green) class? Hmm, not to sure about that one, I deliberately did not emphasize the message in case there are jobs configured, keeping the output rather neutral. But I am open for opinions on this one. However, I will include the question mark icon in case of the unknown job config state. The main focus should be on possibly missing job configurations, configured jobs might still have issues and need to be checked in the tasks logs. > > > There are also a few linting issues: > > 3 issues marked with (*) could be auto-fixed using '--fix'. > [./datastore/Summary.js]: > WARN: line 123 col 4: comma-dangle - Missing trailing comma. (*) > WARN: line 138 col 4: comma-dangle - Missing trailing comma. (*) > WARN: line 153 col 4: comma-dangle - Missing trailing comma. (*) Yes, missed those as well, will be fixed in a new version. Thank you for your comments!