From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5514EA1035 for ; Fri, 10 Nov 2023 13:04:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3D35D1FCC7 for ; Fri, 10 Nov 2023 13:04:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 10 Nov 2023 13:04:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0132A4790A; Fri, 10 Nov 2023 13:04:25 +0100 (CET) Message-ID: <925e1f3c-289c-4b45-8dce-2995c49d32ae@proxmox.com> Date: Fri, 10 Nov 2023 13:04:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Content-Language: en-US To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20230929133924.2731714-1-d.csapak@proxmox.com> <7a67722c-11e9-4a16-ad15-64f8dd0ca857@proxmox.com> From: Dominik Csapak In-Reply-To: <7a67722c-11e9-4a16-ad15-64f8dd0ca857@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape: restore: improve variable names X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2023 12:04:26 -0000 On 11/10/23 13:03, Thomas Lamprecht wrote: > Am 29/09/2023 um 15:39 schrieb Dominik Csapak: >> some of the variable names did not really tell the full story, so extend >> them a bit. This makes the intention much clearer. >> >> Signed-off-by: Dominik Csapak >> --- >> www/tape/window/TapeRestore.js | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> > > applied series with Mira's T-b, thanks! > > ps. using --- as delimiter for code, as you did in the second patch, breaks > `git am` a bit, as that command then thinks the boundary between commit > message and git diff-stat was already hit and truncates the commit message. > I swapped the triple-minus with triple-backticks. oops, sorry and good to know. thanks for the fixup!